-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps-dev): bump serialize-javascript from 1.3.0 to 2.1.2 #10914
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove the webpack upgrade and the yarn.lock modification, please?
@posva it's done. Sincerely I tried to found a reason for the pinned version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It's fine for webpack. It will be updated at a different time |
@posva any idea about when it's gonna be released? |
Hey @mateusvelleda, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
What kind of change does this PR introduce?
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)Other information:
Since I couldn't find the reason for pinning
webpack
at shakir-abdo@bb0aab6 I just upgrade it. I've done it due towebpack#terser-webpack-plugin#serialize-javascript
that would keep the vulnerable version in the deps