Skip to content

Commit

Permalink
fix(patch): clone insert hooks to avoid being mutated during iteration
Browse files Browse the repository at this point in the history
  • Loading branch information
xiaodemen committed Dec 19, 2022
1 parent 2e57061 commit 8da0b15
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/core/vdom/patch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -878,8 +878,11 @@ export function createPatchFunction(backend) {
const insert = ancestor.data.hook.insert
if (insert.merged) {
// start at index 1 to avoid re-invoking component mounted hook
for (let i = 1; i < insert.fns.length; i++) {
insert.fns[i]()
// clone insert hooks to avoid being mutated during iteration.
// e.g. for customed directives under transition group.
const cloned = insert.fns.slice(1)
for (let i = 0; i < cloned.length; i++) {
cloned[i]()
}
}
} else {
Expand Down
38 changes: 38 additions & 0 deletions test/unit/modules/vdom/patch/edge-cases.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -467,4 +467,42 @@ describe('vdom patch: edge cases', () => {
vm.visible = false
vm.$nextTick(done)
})

it('should call directive\'s inserted hook correctly when template root is changed', done => {
let insertCalled = false
const vm = new Vue({
data: {
isOn: false
},
components: {
'v-switch': {
props: {
on: Boolean
},
template: `
<div v-if="on" key="on">On</div>
<div v-else key="off">Off</div>`
}
},
directives: {
foo: {
inserted() {
insertCalled = true
}
}
},
template: `
<transition-group>
<v-switch key="swicth" v-foo :on="isOn"/>
</transition-group>
`
}).$mount()

vm.isOn = true
insertCalled = false
waitForUpdate(() => {
expect(vm.$el.textContent).toMatch('On')
expect(insertCalled).toBe(true)
}).then(done)
})
})

0 comments on commit 8da0b15

Please sign in to comment.