fix history.replaceState() with base and null url #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
added a commit
that referenced
this pull request
Jan 29, 2016
fix history.replaceState() with base and null url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the standard, if the URL parameter is omitted (or
null) from thehistory.replaceState()call, the new URL should be the URL of the current entry. In Safari, however, when a<base>tag is present, if you omit the URL parameter, then Safari will assign the URL of the current entry to the base tag's href. This essentially breaks HTML5 history completely for Safari.The bug I'm referring to seems to be exactly this one (but for Safari not Chrome).
I'm using the latest version of Safari (9.0.3).
I would've written a test for this, but you haven't configured a Safari Selenium driver (it's an OSX thing, so I dunno if that's able to be tested as part of your CI setup).