fix(create-mathcer): remove duplicated decodeURIComponent #3268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, checking this issue #2725
I found that removing the
decodeURIComponent
from thematchRoute
kinda resolve the problem, because the param already comes decoded.I don't know if this is the proper way to fix this issue, but I will give some examples below that worked for me:
URL: /route-matching/params/%252520-working/bar
PS*: Check the
foo
paramWithout the fix :
After the change:
This example was also broking:
URL: /route-matching/params/100%25-working/bar"
Closes #2725
Closes #3138