Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch URI malformed error (fix #2725) #3213

Closed
wants to merge 2 commits into from
Closed

Catch URI malformed error (fix #2725) #3213

wants to merge 2 commits into from

Conversation

aradjdi
Copy link

@aradjdi aradjdi commented May 29, 2020

Fix url decoding when we have a percentage character in URL

hareku and others added 2 commits May 29, 2020 16:24
Error.stack is non standard

Co-authored-by: Eduardo San Martin Morote <[email protected]>

This reverts commit beca9d2.
@posva
Copy link
Member

posva commented Jun 24, 2020

Thank you but this is not the right fix. The problem is the codebase is decoding twice. Example going to /%252520 will create a path of /%2520 and if there is a param (/:text), the param will be %20 but the path should be the same as the one in the URL and the param should be /%2520 (first percentage encoded character is decoded)

@posva posva closed this Jun 24, 2020
@claudiolcastro
Copy link

Hello @posva,

Just removing the decodeURIComponent from matchRoute would resolve the issue??

Can you tell me where is the other place that the param is been decoded??

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants