better error message when component is a promise (fix #3167) #3174
Conversation
There was a problem hiding this comment.
I think this could help a few people, could you align with the message on vue-router-next (https://github.com/vuejs/vue-router-next/blob/master/src/navigationGuards.ts#L173) and add a unit test please?
There was a problem hiding this comment.
There is still a need to check for components option. I think it makes more sense to check for this when trying to fetch the component like it's done at https://github.com/vuejs/vue-router-next/blob/master/src/navigationGuards.ts
| if (route.component && route.component.toString) { | ||
| assert( | ||
| route.component.toString() !== '[object Promise]', | ||
| `Component "${String(name)}" in record with path "${path}" is a Promise instead of a function that returns a Promise. Did you write "import('./MyPage.vue')" instead of "() => import('./MyPage.vue')"?` |
There was a problem hiding this comment.
The name here is the name of the route, not the name of the view (eg default) like at https://github.com/vuejs/vue-router-next/blob/master/src/navigationGuards.ts#L168
| @@ -70,6 +70,12 @@ function addRouteRecord ( | |||
| path || name | |||
| )} cannot be a ` + `string id. Use an actual component instead.` | |||
| ) | |||
| if (route.component && route.component.toString) { | |||
| assert( | |||
| route.component.toString() !== '[object Promise]', | |||
There was a problem hiding this comment.
Let's check for then in case of poly fills like at https://github.com/vuejs/vue-router-next/blob/master/src/navigationGuards.ts#L171
Closes #3167