Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds note on subfolders to history mode samples #2954

Merged
merged 3 commits into from
Oct 4, 2019
Merged

Adds note on subfolders to history mode samples #2954

merged 3 commits into from
Oct 4, 2019

Conversation

AVGP
Copy link
Contributor

@AVGP AVGP commented Oct 3, 2019

fixes #2863

posva
posva approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Before merging I want to know for sure that the change of the Apache rule is accurate. @phanan maybe you can confirm?

@phanan
Copy link
Member

phanan commented Oct 4, 2019

@posva I have not much experience with vue-router deployed in a subdirectory, but the Apache config looks legit :) The additional text misses a dot though.

@posva
Copy link
Member

posva commented Oct 4, 2019

Thanks for the quick feedback!

@posva posva merged commit ca19a1f into vuejs:dev Oct 4, 2019
@vue-bot
Copy link

vue-bot commented Oct 4, 2019

Thanks again! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve history mode server configuration documentation to include non-root publicPath
4 participants
@AVGP @phanan @posva @vue-bot