-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression] Using router methods without Vue instance causes error #922
Comments
blake-newman
changed the title
[Regression] [PhantomJS] Error occurs with unit tests
[Regression] Using router methods without Vue instance causes error
Nov 21, 2016
blake-newman
added a commit
to blake-newman/vue-router
that referenced
this issue
Nov 22, 2016
blake-newman
added a commit
to blake-newman/vue-router
that referenced
this issue
Nov 22, 2016
Same problem here, only working if I use |
I think this should be reopened. I am still getting the same error as @blake-newman when using
|
@samrose3 If that the case, can you open a new issue with a minimal repro, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Source location
Git Bisect points at 83418bc
Using router methods without Vue instance causes the above error. This affects unit tests with PhantomJS due to a
popstate
event after tests are finished. This also breaks when using the feature as intended.Note: The line that causes the error is to ensure that asynchronous components are resolved before callbacks are executed. We can not rely on the
router.app
as this may not be available.The text was updated successfully, but these errors were encountered: