Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Named catch-all route warns if pathMatch is empty #3072

Closed
posva opened this issue Dec 20, 2019 · 2 comments · Fixed by #3081, WFCD/warframe-hub#411, MichaelKohler/reps-voting-analysis#20, OpenTMI/opentmi-default-gui#29 or LuisAlejandro/luisalejandro.github.io-legacy#82
Closed

Named catch-all route warns if pathMatch is empty #3072

posva opened this issue Dec 20, 2019 · 2 comments · Fixed by #3081, WFCD/warframe-hub#411, MichaelKohler/reps-voting-analysis#20, OpenTMI/opentmi-default-gui#29 or LuisAlejandro/luisalejandro.github.io-legacy#82
Labels
contribution welcome good first issue improvement

Comments

@posva
Copy link
Member

posva commented Dec 20, 2019

Version

3.1.3

Reproduction link

http://jsfiddle.net/yza5k02v/

Steps to reproduce

  • click on /nope
  • click on button

What is expected?

no warn

What is actually happening?

there is a warn

maybe the param should be marked as optional to prevent this warning from ever happening
@posva posva mentioned this issue Dec 20, 2019
Closed
@yinm
Copy link
Contributor

yinm commented Dec 24, 2019

Can I work on this?

@kazupon
Copy link
Member

kazupon commented Dec 24, 2019

@yinm
You can contribute to it!

@yinm yinm mentioned this issue Dec 26, 2019
Merged
posva pushed a commit that referenced this issue Dec 30, 2019
@yinm @posva
fix: suppress warning if pathMatch is empty (#3081)
ddc6bc7 
Fix #3072
This was referenced Mar 1, 2020
Open
Open
This was referenced Mar 10, 2020
Open
Closed
Merged
This was referenced Mar 19, 2020
Merged
Merged
This was referenced Mar 28, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this issue Apr 6, 2020
Closed
This was referenced Apr 15, 2020
Open
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome good first issue improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

no warn if pathMatch is empty (fix #3072) yinm/vue-router
[Snyk] Upgrade vue-router from 3.1.3 to 3.1.6 WFCD/warframe-hub
[Snyk] Upgrade vue-router from 3.1.3 to 3.1.6 MichaelKohler/reps-voting-analysis
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.6 OpenTMI/opentmi-default-gui
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.6 LuisAlejandro/luisalejandro.github.io-legacy
[Snyk] Upgrade vue-router from 3.1.3 to 3.1.6 noprotocol/Bubblicious
[Snyk] Upgrade vue-router from 3.1.3 to 3.1.5 MgenGlder/FcsToolbar
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.5 qsays/garden
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.5 hemanthgk10/vue-js-sample-script2
[Snyk] Upgrade vue-router from 3.0.6 to 3.1.6 mc-ireiser/coreui-free-vue-admin-template
3 participants
@kazupon @posva @yinm