Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.8 & 3.0 router-view props bug #1800

Closed
Yusoo opened this issue Oct 12, 2017 · 3 comments
Closed

2.8 & 3.0 router-view props bug #1800

Yusoo opened this issue Oct 12, 2017 · 3 comments

Comments

@Yusoo
Copy link

Yusoo commented Oct 12, 2017

Version

2.8.0

Reproduction link

http://jsfiddle.net/9r6xhqbp/38/

Steps to reproduce

click /foo, msg is undefined

What is expected?

before 2.8.0, msg == 123

What is actually happening?

msg is undefined

@alexsasharegan
Copy link

alexsasharegan commented Oct 12, 2017

I'm also having this issue using route params. My route param will be initially passed, but then updated as an empty string.

const routes = {
  {
    name: "cluster-select",
    path: "/uploadconfigure/clusters/select/cluster/:slugName?",
    props: true,
    component: HdClusterViz,
    beforeEnter: (to, from, next) => {
      const selectedCluster = store.getters["clusters/clustersBySlugName"][to.params.slugName]
      if (selectedCluster) {
        store.dispatch("clusters/selectCluster", selectedCluster)
      } else {
        store.dispatch("clusters/deselectCluster")
      }
      next()
    }
  }
}

Reverting to 2.7.x fixed this for me.

@vuejs vuejs deleted a comment from yyikaka Oct 12, 2017
@amirrustam
Copy link

I'm also experiencing this issue. Tested with both 2.8.0 and 3.0.0. I get a missing prop error for a router-view that accepts a prop. I also had to revert to 2.7.0 to get things back to normal.

@tri-chandra
Copy link

If you are navigating programmatically, in $router.push() you could pass the props there. However, this is a painful solution, reverting to 2.7.0 is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants