Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SafariNomoduleFixPlugin): use RawSource instead of a plain object #6470

Merged
merged 2 commits into from
May 14, 2021
Merged

fix(SafariNomoduleFixPlugin): use RawSource instead of a plain object #6470

merged 2 commits into from
May 14, 2021

Conversation

KaelWD
Copy link
Contributor

@KaelWD KaelWD commented May 11, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:
Writing plain objects to compilation.assets can cause the following error:

UnhandledPromiseRejectionWarning: TypeError: asset.map is not a function
    at getTaskForFile (/home/kael/Documents/vuetifyjs/vuetify-next/packages/docs/node_modules/webpack/lib/SourceMapDevToolPlugin.js:88:47)
    at /home/kael/Documents/vuetifyjs/vuetify-next/packages/docs/node_modules/webpack/lib/SourceMapDevToolPlugin.js:272:22
    at /home/kael/Documents/vuetifyjs/vuetify-next/packages/docs/node_modules/webpack/lib/Cache.js:93:5

@KaelWD KaelWD mentioned this pull request May 11, 2021
Merged
4 tasks
@KaelWD
Copy link
Contributor Author

KaelWD commented May 12, 2021

This looks like a timing problem with the e2e tests:
image

@haoqunjiang haoqunjiang merged commit ca26f8c into vuejs:dev May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
PR: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KaelWD @haoqunjiang