fix(eslint): invalidate the cache when .eslintignore changes
#5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the .eslintignore file to the cache generation algorithm
haoqunjiang
changed the title
.eslintignore changes
haoqunjiang
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the .eslintignore file to the cache generation algorithm
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Other information:
eslint-loader运行时会生成cache，再次运行时，会检查cache是否可用理论上
.eslintignore发生变化时，cache应该失效，重新运行但
@vue/cli-plugin-eslint没有把该文件加入cache的生成算法中从而导致了当
.eslintignore发生变化时，cache没有失效，eslint忽略规则没有生效所以需要将
.eslintignore文件加入到cache处理中