Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don’t prevent the browser’s default behavior for modifier keys #67

Closed
wants to merge 1 commit into from
Closed

Conversation

yuheiy
Copy link

@yuheiy yuheiy commented Aug 8, 2020

The router seems to prevent the browser’s default behavior for modifier keys on link clicks. This PR changes the browser’s default behavior to take precedence when users are using modifier keys.

Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM 👍

@kiaking
Copy link
Member

kiaking commented Sep 3, 2020

Hi thank you so much for the PR! We went and merged #69 which is the exact same PR with this one, but slightly different code stylings. Sorry It took long before looking into this, but we appreciate so much!

@kiaking kiaking closed this Sep 3, 2020
@kiaking kiaking added the duplicate This issue or pull request already exists label Sep 3, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants