Skip to content

fix: gap between VPNavBar and VPNavScreen when navbar partially scrolled on mobile #4978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: gap between VPNavBar and VPNavScreen when navbar partially scrolled on mobile #4978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions src/client/theme-default/components/VPNavScreen.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script setup lang="ts">
import { useScrollLock } from '@vueuse/core'
import { useCssVar, useScrollLock, useWindowScroll } from '@vueuse/core'
import { inBrowser } from 'vitepress'
import { ref } from 'vue'
import { computed, ref } from 'vue'
import VPNavScreenAppearance from './VPNavScreenAppearance.vue'
import VPNavScreenMenu from './VPNavScreenMenu.vue'
import VPNavScreenSocialLinks from './VPNavScreenSocialLinks.vue'
Expand All @@ -13,6 +13,26 @@ defineProps<{

const screen = ref<HTMLElement | null>(null)
const isLocked = useScrollLock(inBrowser ? document.body : null)

const { y } = useWindowScroll()
const navHeightVar = inBrowser
? useCssVar('--vp-nav-height', document.documentElement)
: ref('0')
const layoutTopHeightVar = inBrowser
? useCssVar('--vp-layout-top-height', document.documentElement)
: ref('0')

const screenTop = computed(() => {
if (!inBrowser) {
return '0px'
}

const navHeight = Number.parseFloat(navHeightVar.value || '0')
const layoutTopHeight = Number.parseFloat(layoutTopHeightVar.value || '0')
const remainingNav = Math.max(navHeight - y.value, 0)

return `${layoutTopHeight + remainingNav}px`
})
</script>

<template>
Expand All @@ -21,7 +41,13 @@ const isLocked = useScrollLock(inBrowser ? document.body : null)
@enter="isLocked = true"
@after-leave="isLocked = false"
>
<div v-if="open" class="VPNavScreen" ref="screen" id="VPNavScreen">
<div
v-if="open"
class="VPNavScreen"
ref="screen"
id="VPNavScreen"
:style="{ top: screenTop }"
>
<div class="container">
<slot name="nav-screen-content-before" />
<VPNavScreenMenu class="menu" />
Expand Down