Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: import code snippet with region (#237) #238

Merged
merged 6 commits into from
Apr 8, 2021
Merged

feat: import code snippet with region (#237) #238

merged 6 commits into from
Apr 8, 2021

Conversation

mysticmind
Copy link
Contributor

@mysticmind mysticmind commented Feb 11, 2021 •
edited
Loading

  • Add functionality for import code snippet with region
  • Add docs for import code snippet

Both the above are adapted from the VuePress functionality and docs.

Closes #237

@mysticmind mysticmind mentioned this pull request Feb 12, 2021
Closed
@mysticmind
Copy link
Contributor Author

Quick note, this PR is ready for review and next steps.

@mysticmind
Copy link
Contributor Author

Any idea when this PR would be reviewed for next steps?

@kiaking kiaking added the enhancement New feature or request label Apr 8, 2021
kiaking
kiaking approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@kiaking kiaking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for the awesome PR 🙌

@kiaking kiaking merged commit d1a62e1 into vuejs:master Apr 8, 2021
@mysticmind mysticmind deleted the import_code_snippet_region_feature branch April 8, 2021 09:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kiaking kiaking kiaking approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import code snippet with region
2 participants
@mysticmind @kiaking