Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: base option not generating correct multi sidebar (#231) #234

Merged
merged 4 commits into from
Feb 11, 2021

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Feb 11, 2021

fix #231

Fixes the issue where when base option is set, multi sidebar fails to retrieve correct sidebar config.

@kiaking kiaking added the bug Something isn't working label Feb 11, 2021
@kiaking kiaking self-assigned this Feb 11, 2021
@kiaking
Copy link
Member Author

kiaking commented Feb 11, 2021

Not directly related to this fix or issue but we get Hydration completed but contains mismatches. when using base option. Seems like active link check for nav items is causing the issue. Will look into a bit deeper and try if I can include the fix in this PR.

@kiaking
Copy link
Member Author

kiaking commented Feb 11, 2021

I think i've fixed it. But I'm maybe not 100% happy with the solution. Maybe we should add another param on route to retrieve path without base, and use that to do any active link checks. That way, the active link check should always work regardless of the base option.

@kiaking
Copy link
Member Author

kiaking commented Feb 11, 2021

And I did.

@kiaking kiaking merged commit a613df4 into master Feb 11, 2021
@kiaking kiaking deleted the 231-fix-sidebar-with-base-option branch February 11, 2021 08:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

base option not generating correct multi sidebar
1 participant