fix: sidebar 'auto' not working (#178) #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #178
Sidebar gets hidden because
auto
was treated as empty. Added helper function to check if the sidebar is empty or not, and refactored a bit on checking logic for better readability 👀This adds a breaking change where undefined sidebar now resolves to
auto
where currently it's treated asfalse
. Though VuePress treats undefined sidebar asauto
so this is how it should have been 😓