Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar 'auto' not working (#178) #224

Merged
merged 2 commits into from
Feb 9, 2021

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Feb 5, 2021

fix #178

Sidebar gets hidden because auto was treated as empty. Added helper function to check if the sidebar is empty or not, and refactored a bit on checking logic for better readability 👀

This adds a breaking change where undefined sidebar now resolves to auto where currently it's treated as false. Though VuePress treats undefined sidebar as auto so this is how it should have been 😓

@kiaking kiaking added the bug Something isn't working label Feb 5, 2021
@kiaking kiaking self-assigned this Feb 5, 2021
@kiaking kiaking force-pushed the 178-fix-sidebar-auto-not-working branch from 00562de to cada4e7 Compare February 9, 2021 12:42
@kiaking kiaking merged commit 5deaf6a into master Feb 9, 2021
@kiaking kiaking deleted the 178-fix-sidebar-auto-not-working branch February 9, 2021 12:46
@cloydlau
Copy link

cloydlau commented Nov 16, 2022

Has this been removed later on? I got a TypeError: Cannot read properties of undefined (reading 'some') with the following config:

sidebar: {
  'XXX': 'auto',
}

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sidebar: 'auto' doesn't create sidebar
2 participants