Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: base option not working on dev mode (#181) #223

Merged
merged 1 commit into from
Feb 5, 2021
Merged

fix: base option not working on dev mode (#181) #223

merged 1 commit into from
Feb 5, 2021

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Feb 5, 2021

fix #181

Now Vite natively supports base option, so all we need to do is pass the option down to the Vite server 💪

@kiaking kiaking added the bug Something isn't working label Feb 5, 2021
@kiaking kiaking self-assigned this Feb 5, 2021
@kiaking kiaking merged commit 0b5b306 into master Feb 5, 2021
@kiaking kiaking deleted the 181-fix-base-option-not-working-on-dev-mode branch February 5, 2021 14:35
@TheDutchCoder TheDutchCoder mentioned this pull request Feb 10, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kiaking kiaking

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dev home page doesn't honor base config
1 participant
@kiaking