Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrollbar when using line highlight #200

Merged
merged 1 commit into from
Jan 5, 2021
Merged

fix: scrollbar when using line highlight #200

merged 1 commit into from
Jan 5, 2021

Conversation

patak-dev
Copy link
Member

Hides spurious scrollbar in code blocks that appears when using line highlighting
https://vitepress.vuejs.org/guide/markdown.html#line-highlighting-in-code-blocks

image

@antfu antfu merged commit b6ba8a9 into vuejs:master Jan 5, 2021
@patak-dev
Copy link
Member Author

I just opened #201, the direct link I included in the description was not actually working. Maybe an SSR issue.

@antfu should I send a PR for the styling of the scrollbars too? Not every app does it, GitHub is leaving the default ones for windows. VuePress also leaves the default ones, maybe this is something that users could decide actually.

@antfu
Copy link
Member

antfu commented Jan 5, 2021

RE: Scrollbar. I think it's better to keep the default style, as documentation tools we shouldn't bring too many opinions on native elements.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants