fix($theme-default): display header-anchor links when using keyboard navigation #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh neat! Thank you so much 🙌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a11y: When using keyboard navigation the header-anchor link (the # tag before the heading) is not visible, this PR fixies this bug.
To recreate the issue, try navigating using you keyboard (with the
TABkey) in a page with manyh1-h6headings. You won't see the heading-anchor link (the # tag before the heading). But when you hover with your mouse over a heading you will see the heading-anchor link.Why? because the code uses only
:hover(for mouse users). It should also include:focus(for keyboard users).The same PR accepted on vuePress, see vuejs/vuepress#2699