Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): allow open new tab with ctrl + click #69

Merged
merged 2 commits into from
Sep 3, 2020
Merged

fix(router): allow open new tab with ctrl + click #69

merged 2 commits into from
Sep 3, 2020

Conversation

pikax
Copy link
Member

@pikax pikax commented Aug 22, 2020

Let the browser open the link if shift/ctrl/meta key is pressed

@kiaking
Copy link
Member

kiaking commented Sep 3, 2020

Thanks! This is duplicate of #67. Code is almost identical, with small styling difference 😅 Let's Evan decide which style he likes more

@antfu
Copy link
Member

antfu commented Sep 3, 2020 •
edited
Loading

For the styling, I would say I like one better over 67 as this is more straightforward with fewer types of operators 😁.

@kiaking kiaking added the bug Something isn't working label Sep 3, 2020
@kiaking
Copy link
Member

kiaking commented Sep 3, 2020

Ah, fewer types operators sounds yummy... OK let's merge this one 👍

@kiaking kiaking merged commit 092ee77 into vuejs:master Sep 3, 2020
@kiaking kiaking mentioned this pull request Sep 3, 2020
Closed
@pikax pikax deleted the fix/do_not_handle_the_link_if_an_special_key_is_pressed branch September 3, 2020 07:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pikax @kiaking @antfu