$title compat with vuepress

[patak-dev]

@kiaking when working on #152, I assumed that it was the title that appeared in the sidebar links:

$title = $page.title || $site.title

But reviewing the code in Vuepress, it looks like it is actually the title of the document:

$title = ( $page.title ? $page.title + ' | ' + $site.title ) : $site.title

I think it is more useful as we have it (and maybe add a $documentTitle), but maybe we need to align it to vuepress and have:

$title <- same as in vuepress
$sidebarTitle <- current one (or we do not expose this one at all)

It will be an interesting walk to keep as much of compat with vuepress but take the opportunity to break what could be improved. I am fine with both options here.

Thoughts?

[kiaking]

Ah, nice catch. I think we should align with VuePress about this one. Since $description is getting the actual description for the site, we should do same with the $title too.

But I understand the pain. How about making $page.title always exist as you mentioned in another issue. So page title becomes:

infertTitle(page.title) || siteDataByRoute.title

Since it's essential for pages to have title so 😳

[patak-dev]

I agree with both.

I'll send a PR 👍

[kiaking]

Wonderful! 🙌