Skip to content

Commit

Permalink
refactor: float h2 code block when there's carbon ads
Browse files Browse the repository at this point in the history
  • Loading branch information
kiaking committed Nov 26, 2020
1 parent 8c94cab commit fad85b8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/client/theme-default/styles/code.css
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ div[class*='language-'] {
position: relative;
margin: 1rem -1.5rem;
background-color: var(--code-bg-color);
overflow-x: auto;
}

li > div[class*='language-'] {
Expand Down
1 change: 1 addition & 0 deletions src/client/theme-default/styles/layout.css
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ h2 {
padding-bottom: .3rem;
line-height: 1.25;
font-size: 1.65rem;
overflow-x: auto;

This comment has been minimized.

Copy link
@yyx990803

yyx990803 Dec 5, 2020

Member

I'm not sure what this is fixing but it breaks h2 anchor hovers so I'm reverting it.

This comment has been minimized.

Copy link
@kiaking

kiaking Dec 5, 2020

Author Member

This is to make border-bottom float correctly when there is an ads. You can see that the border is going under the ads block.

Screen Shot 2020-12-05 at 14 04 08

Though, it looks good enough so I guess it's OK to not overflow h2 👍

}

h2 + h3 {
Expand Down

0 comments on commit fad85b8

Please sign in to comment.