fix: handle links that embed other elements (#2)

This fixes the case, when for example `a` tag, wraps an `img` tag.
vuejs · May 4, 2020 · 4cbfc60 · 4cbfc60
1 parent a3df035
commit 4cbfc60
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/app/router.js b/lib/app/router.js
@@ -112,8 +112,9 @@ export function createRouter(loadComponent, fallbackComponent) {
        * @param {*} e
        */
       (e) => {
-        if (e.target.tagName === 'A') {
-          const { href, target } = e.target
+        const link = e.target.closest('a')
+        if (link) {
+          const { href, target } = link
           const targetUrl = new URL(href)
           const currentUrl = window.location
           if (
@@ -127,7 +128,7 @@ export function createRouter(loadComponent, fallbackComponent) {
                 e.preventDefault()
                 window.scrollTo({
                   left: 0,
-                  top: e.target.offsetTop,
+                  top: link.offsetTop,
                   behavior: 'smooth'
                 })
               }