Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partially fix #355, a crude watcher #702

Merged
merged 2 commits into from
Feb 20, 2018

Conversation

HerringtonDarkholme
Copy link
Member

No description provided.

@HerringtonDarkholme HerringtonDarkholme merged commit 3f260a5 into vuejs:master Feb 20, 2018
@octref
Copy link
Member

octref commented Feb 21, 2018

I don't think this should go in...I'm working on using something along this line and centralizing the file watching & version invalidation.

@HerringtonDarkholme
Copy link
Member Author

HerringtonDarkholme commented Feb 21, 2018

I don't think we should rely on client behavior. As far as I know, few clients other than vscode itself support synchronization.

And I believe this is why tsserver also implents watching itself.

@octref
Copy link
Member

octref commented Feb 21, 2018

Yeah then those clients need to implement it because Text Synchronization is part of LSP.

I'm not in a hurry to convert the file watching all to synchronization so other clients can continue to use VLS for now. However, if you want to have file watching not using synchronization, I suggest having just one watcher for all files (not in specific modes) and combine it with a better TextDocument manager that track versions and some meta info (think of a redux on the top of the server). This will help #681 and open door for #130.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants