Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use Vue TS plugin #2145

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: use Vue TS plugin #2145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbea387
feat: use Vue TS plugin
znck Aug 8, 2020
973ea1e
chore: use exact version
znck Aug 8, 2020
b99cd04
update ts-plugin with fixes in component tag renaming
znck Aug 9, 2020
d01644b
fix: remove Vue version check for now
znck Aug 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions client/vueMain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ export async function activate(context: vscode.ExtensionContext) {
console.log('Client initialization failed');
});

const ts = vscode.extensions.getExtension('vscode.typescript-language-features');
if (ts) {
if (!ts.isActive) { ts.activate(); }
}

return vscode.window.withProgress(
{
title: 'Vetur initialization',
Expand Down
48 changes: 47 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
"vscode": "^1.47.0"
},
"dependencies": {
"@vuedx/typescript-vetur": "^0.2.3",
"vscode-languageclient": "^6.1.3",
"vscode-languageserver-types": "^3.15.1"
},
Expand Down Expand Up @@ -511,9 +512,54 @@
"type": "boolean",
"default": false,
"description": "Enable template interpolation service that offers diagnostics / hover / definition / references."
},
"vetur.typescript.suggest.enabled": {
"type": "boolean",
"default": false,
"description": "Enabled/disable autocomplete suggestions.",
"scope": "resource"
},
"vetur.typescript.format.enable": {
"type": "boolean",
"default": false,
"description": "Enable/disable default TypeScript/JavaScript formatter.",
"scope": "window"
},
"vetur.typescript.implementationsCodeLens.enabled": {
"type": "boolean",
"default": false,
"description": "Enable/disable implementations CodeLens. This CodeLens shows the implementers of an interface.",
"scope": "window"
},
"vetur.typescript.suggest.completeJSDocs": {
"type": "boolean",
"default": false,
"description": "Enable/disable suggestion to complete JSDoc comments.",
"scope": "resource"
},
"vetur.typescript.referencesCodeLens.enabled": {
"type": "boolean",
"default": false,
"description": "Enable/disable references CodeLens in TypeScript/JavaScript files.",
"scope": "window"
},
"vetur.typescript.autoClosingTags": {
"type": "boolean",
"default": false,
"description": "Enable/disable automatic closing of JSX tags. Requires using TypeScript 3.0 or newer in the workspace."
}
}
}
},
"typescriptServerPlugins": [
{
"name": "@vuedx/typescript-vetur",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is @vuedx/typescript-vetur and where is its source code located?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/znck/vue-developer-experience/blob/master/packages/typescript-vetur/src/index.ts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's TS plugin version for vetur.

/cc @octref

"enableForWorkspaceTypeScriptVersions": true,
"configNamespace": "vetur.typescript",
"languages": [
"vue"
]
}
]
},
"devDependencies": {
"@types/glob": "^7.1.3",
Expand Down
Loading