Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize all file system access in VLS #800

Closed
octref opened this issue May 21, 2018 · 2 comments
Closed

Centralize all file system access in VLS #800

octref opened this issue May 21, 2018 · 2 comments

Comments

@octref
Copy link
Member

octref commented May 21, 2018

Motivation

Currently Vetur's file system access is scattered throughout the code. However, we also use TextDocuments from https://github.com/Microsoft/vscode-languageserver-node to track LSP documents, and with the new FileEvents generated through VS Code file watcher, it's time to put these all together.

Benefits

  • All file access / events in one place. Easier to track, log, do perf analysis, etc
  • Possible to use in-memory / virtual FS system with VLS
  • Easier to manage the "virtual files" we generate for each region in Vue files
  • Possible to reduce chattiness of LSP by switching to Incremental Syncing
  • Possible to listen to changes by granularity of Vue regions (as compared to currently letting each file change triggering all features in file)

Fixes

Unblocks

@s-KaiNet
Copy link

image
Looking forward to see this issue fixed with PR and new version published.
Thank you for your great efforts you invest in this (and other) OSS projects!

octref added a commit that referenced this issue Jun 3, 2018
[WIP] Initial cut for document manager. #800
@octref octref mentioned this issue Aug 13, 2018
17 tasks
@octref
Copy link
Member Author

octref commented May 10, 2019

Outdated and won't do any more.

@octref octref closed this as completed May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants