Skip to content

feat(language-service): strip ="" for boolean props completion edits #5888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KazariEX merged 9 commits into from
Jan 5, 2026
+22 −1
Merged

feat(language-service): strip ="" for boolean props completion edits #5888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c64219
feat(language-service): rich hover message (#5881)
johnsoncodehk Dec 18, 2025
217d574
fix(language-service): optimism filter
johnsoncodehk Dec 18, 2025
b9d6989
feat: strip `=""` for boolean props completion edits
KazariEX Dec 18, 2025
ac6e191
Merge branch 'master' into feat/boolean-props-completion
KazariEX Dec 18, 2025
342cf6e
Merge branch 'master' into pr/5888
johnsoncodehk Dec 19, 2025
2d206ce
refactor: use `type`
KazariEX Dec 20, 2025
c7a56fa
Merge branch 'master' into feat/boolean-props-completion
KazariEX Jan 5, 2026
5044ee2
test: add
KazariEX Jan 5, 2026
11caa15
test: fix
KazariEX Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion packages/language-server/tests/completions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,14 +615,31 @@ test('Auto import', async () => {
`);
});

test('Boolean props', async () => {
await requestCompletionItemToVueServer(
'fixture.vue',
'vue',
`
<template>
<Comp :f| />
</template>

<script setup lang="ts">
declare function Comp(props: { foo: boolean }): void;
</script>
`,
':foo',
);
});

test('Directives', async () => {
await requestCompletionItemToVueServer('fixture.vue', 'vue', `<template><div v-ht|></div></template>`, 'v-html');
await requestCompletionItemToVueServer('fixture.vue', 'vue', `<template><div v-cl|></div></template>`, 'v-cloak');
await requestCompletionItemToVueServer('fixture.vue', 'vue', `<template><div v-el|></div></template>`, 'v-else');
await requestCompletionItemToVueServer('fixture.vue', 'vue', `<template><div v-p|></div></template>`, 'v-pre');
});

test('Directive Modifiers', async () => {
test('Directive modifiers', async () => {
expect(
(await requestCompletionListToVueServer(
'fixture.vue',
Expand Down
4 changes: 4 additions & 0 deletions packages/language-service/lib/plugins/vue-template.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,6 +765,8 @@ export function create(
const name = attrNameCasing === AttrNameCasing.Camel ? prop.name : hyphenateAttr(prop.name);
return name === labelName;
});
const isBoolean = propMeta2?.type === 'boolean' || propMeta2?.type.startsWith('boolean ');

if (addPlainAttrs) {
attributes.push({
name: labelName,
Expand All @@ -775,12 +777,14 @@ export function create(
attributes.push({
name: V_BIND_SHORTHAND + labelName,
description: propMeta2 && createDescription(propMeta2),
valueSet: isBoolean ? 'v' : undefined,
});
}
if (addVBinds) {
attributes.push({
name: DIRECTIVE_V_BIND + labelName,
description: propMeta2 && createDescription(propMeta2),
valueSet: isBoolean ? 'v' : undefined,
});
}
}
Expand Down