Skip to content

fix(typescript-plugin): add nullish guards before accessing ts.CompletionEntryData #5869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnsoncodehk merged 1 commit into from
Dec 13, 2025
Merged

fix(typescript-plugin): add nullish guards before accessing ts.CompletionEntryData #5869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/typescript-plugin/lib/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,10 +517,10 @@ export function resolveCompletionResult<T>(
export function resolveCompletionEntryDetails(
language: Language<any>,
details: ts.CompletionEntryDetails,
data: any,
data: Record<string, any> | undefined,
) {
// modify import statement
if (data.__isComponentAutoImport) {
if (data?.__isComponentAutoImport) {
const { oldName, newName } = data.__isComponentAutoImport;
for (const codeAction of details?.codeActions ?? []) {
for (const change of codeAction.changes) {
Expand All @@ -533,7 +533,7 @@ export function resolveCompletionEntryDetails(
}
}
}
if (data.__isAutoImport) {
if (data?.__isAutoImport) {
const { fileName } = data.__isAutoImport;
const sourceScript = language.scripts.get(fileName);
if (sourceScript?.generated?.root instanceof VueVirtualCode) {
Expand Down