feat(component-meta): add tags to slots and exposed#5862
Merged
johnsoncodehk merged 3 commits intovuejs:masterfrom Dec 13, 2025
Merged
feat(component-meta): add tags to slots and exposed#5862johnsoncodehk merged 3 commits intovuejs:masterfrom
tags to slots and exposed#5862johnsoncodehk merged 3 commits intovuejs:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for JSDoc tags to slot and exposed property metadata, bringing them into alignment with the existing tags support for props and events. The changes enable developers to use JSDoc tags (like @deprecated) consistently across all component metadata types.
- Adds
tagsfield toSlotMetaandExposeMetainterfaces - Refactors tag extraction into a reusable
getJsDocTagshelper function - Updates test files and snapshots to demonstrate tag extraction from reference types
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/component-meta/lib/types.ts | Adds tags field to SlotMeta and ExposeMeta interfaces; also includes unrelated field reordering in PropertyMeta |
| packages/component-meta/lib/base.ts | Implements getJsDocTags helper function and applies it to slot and exposed property resolvers |
| packages/component-meta/tests/index.spec.ts | Adds test assertions to verify tag extraction for slots and exposed properties |
| test-workspace/component-meta/reference-type-slots/my-slots.ts | New test file defining slot interface with JSDoc tags |
| test-workspace/component-meta/reference-type-slots/component-define-slots.vue | Refactored to use external MySlots type for testing tag extraction |
| test-workspace/component-meta/reference-type-exposed/my-exposed.ts | New test file defining exposed interface with JSDoc tags |
| test-workspace/component-meta/reference-type-exposed/component.vue | Refactored to use external MyExposed type for testing tag extraction |
| packages/tsc/tests/snapshots/dts.spec.ts.snap | Updated snapshots reflecting the new type definitions and reference imports |
| README.md | Unrelated documentation improvements (comma additions and command corrections) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
LGTM, thanks for the PR! |
johnsoncodehk
pushed a commit
that referenced
this pull request
Dec 18, 2025
johnsoncodehk
pushed a commit
that referenced
this pull request
Dec 18, 2025
johnsoncodehk
pushed a commit
that referenced
this pull request
Dec 18, 2025
johnsoncodehk
pushed a commit
that referenced
this pull request
Dec 18, 2025
johnsoncodehk
pushed a commit
that referenced
this pull request
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
tagsto slots and exposed so that jsDoc tags can be used consistently across props, events, slots and exposed.