Skip to content

refactor(vscode): update Vue grammar scope name to "text.html.vue"#5856

Merged
johnsoncodehk merged 2 commits intomasterfrom
scopeName
Dec 12, 2025
Merged

refactor(vscode): update Vue grammar scope name to "text.html.vue"#5856
johnsoncodehk merged 2 commits intomasterfrom
scopeName

Conversation

@johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Dec 11, 2025

Change the Vue grammar scope from source.vue to text.html.vue to reflect its HTML superset nature and inherit relevant syntax support.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors Vue grammar scope names from "source.vue" to "text.html.vue" to better align with TextMate grammar conventions for HTML-based languages.

Key Changes:

  • Updated the main Vue grammar scope name in vue.tmLanguage.json
  • Updated scope name references in MDX and Markdown integration files
  • Updated package.json grammar configurations and embedded language mappings
  • Regenerated test snapshots to reflect the new scope names

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
extensions/vscode/syntaxes/vue.tmLanguage.json Updated main scopeName from "source.vue" to "text.html.vue" and internal scope references
extensions/vscode/syntaxes/mdx-vue.json Updated include references from "source.vue" to "text.html.vue"
extensions/vscode/syntaxes/markdown-vue.json Updated include references from "source.vue" to "text.html.vue"
extensions/vscode/package.json Updated all scopeName and embeddedLanguages mappings from "source.vue" to "text.html.vue"
extensions/vscode/tests/__snapshots__/grammar.spec.ts.snap Updated all test snapshot expectations to use "text.html.vue" instead of "source.vue"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@johnsoncodehk johnsoncodehk changed the title refactor(vscode): update Vue grammar scope names to "text.html.vue" refactor(vscode): update Vue grammar scope name to "text.html.vue" Dec 12, 2025
@johnsoncodehk johnsoncodehk marked this pull request as ready for review December 12, 2025 14:03
@johnsoncodehk johnsoncodehk merged commit 784dd56 into master Dec 12, 2025
13 checks passed
@johnsoncodehk johnsoncodehk deleted the scopeName branch December 12, 2025 14:04
jsmnbom added a commit to jsmnbom/graphiql that referenced this pull request Dec 30, 2025
vuejs/language-tools#5856 changed the vue grammar scope from "source.vue" to "text.html.vue".
This change simply adds the new scope to the list of inline injection targets.
Old scope is still supported for backwards compatibility, tho I am unsure if this is necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant