Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove importsNotUsedAsValues #4897

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

KazariEX
Copy link
Collaborator

No description provided.

Copy link

pkg-pr-new bot commented Sep 30, 2024

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4897

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4897

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4897

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4897

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4897

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4897

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4897

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4897

commit: 32f41e0

@KazariEX KazariEX enabled auto-merge (squash) September 30, 2024 09:51
davidmatter
davidmatter previously approved these changes Sep 30, 2024
Copy link
Collaborator

@davidmatter davidmatter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we eventually aim for supporting verbatimModuleSyntax=true? I've looked into it and there would be hundreds of necessary changes.

@KazariEX
Copy link
Collaborator Author

KazariEX commented Sep 30, 2024

It seems that these changes are not destructive, can try doing it this way.

@KazariEX KazariEX changed the title chore: use verbatimModuleSyntax instead refactor: use verbatimModuleSyntax Sep 30, 2024
@KazariEX KazariEX changed the title refactor: use verbatimModuleSyntax refactor: remove importsNotUsedAsValues Sep 30, 2024
This reverts commit 0d06c8d.
@KazariEX KazariEX changed the title refactor: remove importsNotUsedAsValues chore: remove importsNotUsedAsValues Sep 30, 2024
@johnsoncodehk
Copy link
Member

johnsoncodehk commented Oct 25, 2024

Should we eventually aim for supporting verbatimModuleSyntax=true? I've looked into it and there would be hundreds of necessary changes.

I've tried several times and the current conclusion is that verbatimModuleSyntax is not suitable for CJS projects.

As an alternative to importsNotUsedAsValues, we need to use the equivalent ESLint rule in tsslint.config.ts.

@johnsoncodehk johnsoncodehk merged commit c47d53f into vuejs:master Oct 25, 2024
5 checks passed
@KazariEX KazariEX deleted the chore/tsconfig-deprecated branch October 25, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants