Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing schema to rule order-in-components #74

Merged
merged 1 commit into from
Jul 14, 2017
Merged

Add missing schema to rule order-in-components #74

merged 1 commit into from
Jul 14, 2017

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Jul 14, 2017 •
edited
Loading

Rule vue/order-in-components throws eslint rule schema validation error on custom order
bacause is missing schema definition

issue: #73

@armano2 armano2 changed the title vue/order-in-components throws eslint rule schema validation add schema to vue/order-in-components #73 Jul 14, 2017
@armano2 armano2 changed the title add schema to vue/order-in-components #73 Add missing schema to vue/order-in-components Jul 14, 2017
@armano2 armano2 changed the title Add missing schema to vue/order-in-components Add missing schema to rule order-in-components Jul 14, 2017
michalsnik
michalsnik approved these changes Jul 14, 2017
View reviewed changes
Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right! No idea how I had missed that.. Thanks a lot!

@michalsnik michalsnik merged commit 799d1de into vuejs:master Jul 14, 2017
@armano2 armano2 deleted the patch-3-order-in-components-schema branch July 14, 2017 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsnik michalsnik michalsnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armano2 @michalsnik