Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add slot-name-casing rule #2620

Merged
merged 4 commits into from
Nov 27, 2024
Merged

feat: add slot-name-casing rule #2620

merged 4 commits into from
Nov 27, 2024
+323 −3

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Nov 22, 2024

resolve #2580

ota-meshi
ota-meshi approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@ota-meshi ota-meshi force-pushed the feature/slot-name-casing branch from c6cc9dc to 7d65824 Compare November 27, 2024 08:07
@FloEdelmann FloEdelmann force-pushed the feature/slot-name-casing branch from 7d65824 to c5730a8 Compare November 27, 2024 08:37
FloEdelmann
FloEdelmann requested changes Nov 27, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, but I have a few minor suggestions.

lib/rules/slot-name-casing.js Outdated Show resolved Hide resolved
docs/rules/slot-name-casing.md Outdated Show resolved Hide resolved
tests/lib/rules/slot-name-casing.js Outdated Show resolved Hide resolved
tests/lib/rules/slot-name-casing.js Outdated Show resolved Hide resolved
tests/lib/rules/slot-name-casing.js Outdated Show resolved Hide resolved
tests/lib/rules/slot-name-casing.js Outdated Show resolved Hide resolved
tests/lib/rules/slot-name-casing.js Outdated Show resolved Hide resolved
@waynzh waynzh requested a review from FloEdelmann November 27, 2024 09:00
FloEdelmann
FloEdelmann approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂

@FloEdelmann FloEdelmann merged commit a270df8 into vuejs:master Nov 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: slot-name-casing
3 participants
@waynzh @FloEdelmann @ota-meshi