Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ignoreTags option #2609

Merged
merged 12 commits into from
Nov 27, 2024
Merged

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Nov 16, 2024

resolve #2605

Add an exclude option to exclude specified tag names in the vue/attribute-hyphenation and vue/v-on-event-hyphenation rules.

docs/rules/attribute-hyphenation.md Outdated Show resolved Hide resolved
@FloEdelmann FloEdelmann changed the title feat: add exclude tag names option feat: add ignoreTags option Nov 19, 2024
docs/rules/attribute-hyphenation.md Outdated Show resolved Hide resolved
docs/rules/attribute-hyphenation.md Outdated Show resolved Hide resolved
docs/rules/attribute-hyphenation.md Outdated Show resolved Hide resolved
docs/rules/attribute-hyphenation.md Outdated Show resolved Hide resolved
docs/rules/v-on-event-hyphenation.md Outdated Show resolved Hide resolved
lib/rules/attribute-hyphenation.js Outdated Show resolved Hide resolved
lib/rules/attribute-hyphenation.js Outdated Show resolved Hide resolved
lib/rules/v-on-event-hyphenation.js Outdated Show resolved Hide resolved
tests/lib/rules/attribute-hyphenation.js Show resolved Hide resolved
tests/lib/rules/attribute-hyphenation.js Show resolved Hide resolved
@waynzh
Copy link
Member Author

waynzh commented Nov 20, 2024

I've addressed the suggestions. Thanks for the review!

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂
Thanks for your contribution and for implementing the feedback!

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@ota-meshi ota-meshi merged commit 9ddf3e5 into vuejs:master Nov 27, 2024
11 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude some tags from vue/v-on-event-hyphenation and vue/attribute-hyphenation
3 participants