Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(custom-event-name-casing): check defineEmits variable name in template #2585

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(custom-event-name-casing): check defineEmits variable name in template #2585

merged 1 commit into from
Oct 28, 2024

Conversation

waynzh
Copy link
Member

@waynzh waynzh commented Oct 26, 2024

fix #2577

ota-meshi
ota-meshi approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi requested a review from FloEdelmann October 28, 2024 00:39
@ota-meshi ota-meshi merged commit 86300c4 into vuejs:master Oct 28, 2024
18 checks passed
@waynzh waynzh mentioned this pull request Nov 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/custom-event-name-casing doesn't flag incorrectly cased emits in the template
3 participants
@waynzh @FloEdelmann @ota-meshi