Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(require-toggle-inside-transition): add additionalDirectives option (#2535) #2537

Merged
merged 1 commit into from
Sep 2, 2024
Merged

feat(require-toggle-inside-transition): add additionalDirectives option (#2535) #2537

merged 1 commit into from
Sep 2, 2024

Conversation

cjpearson
Copy link
Contributor

Resolves #2535

FloEdelmann
FloEdelmann requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the two small open threads.

lib/rules/require-toggle-inside-transition.js Outdated Show resolved Hide resolved
@cjpearson cjpearson force-pushed the additional-directives-option branch from c9dea58 to 545af71 Compare August 29, 2024 09:53
FloEdelmann
FloEdelmann requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more small suggestions.

lib/rules/require-toggle-inside-transition.js Outdated Show resolved Hide resolved
lib/rules/require-toggle-inside-transition.js Outdated Show resolved Hide resolved
lib/rules/require-toggle-inside-transition.js Outdated Show resolved Hide resolved
tests/lib/rules/require-toggle-inside-transition.js Outdated Show resolved Hide resolved
@cjpearson cjpearson force-pushed the additional-directives-option branch from 545af71 to dcd4c73 Compare August 29, 2024 11:46
FloEdelmann
FloEdelmann reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny docs improvement, other than that it looks good to me 🙂

Thanks for your contribution!

docs/rules/require-toggle-inside-transition.md Outdated Show resolved Hide resolved
@FloEdelmann FloEdelmann requested a review from ota-meshi August 29, 2024 12:53
@cjpearson cjpearson force-pushed the additional-directives-option branch from 3616733 to d69db95 Compare August 29, 2024 13:12
ota-meshi
ota-meshi approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 889c192 into vuejs:master Sep 2, 2024
18 checks passed
@nerdy-tech-com-gitub nerdy-tech-com-gitub mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynzh waynzh waynzh left review comments

@ota-meshi ota-meshi ota-meshi approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow custom toggles in vue/require-toggle-inside-transition
4 participants
@cjpearson @FloEdelmann @ota-meshi @waynzh