Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements proposed max-template-depth rule #2525

Merged

Conversation

kevsommer
Copy link
Contributor

This PR addresses issue #2524.

I believe it successfully implements the rule, that the test cases are exhaustive enough.

Hoping for feedback! :)

docs/rules/max-template-depth.md Outdated Show resolved Hide resolved
docs/rules/max-template-depth.md Outdated Show resolved Hide resolved
lib/rules/max-template-depth.js Outdated Show resolved Hide resolved
@kevsommer kevsommer requested a review from FloEdelmann August 13, 2024 19:50
@FloEdelmann FloEdelmann linked an issue Aug 14, 2024 that may be closed by this pull request
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙂
Thanks for your contribution!

@FloEdelmann FloEdelmann requested a review from ota-meshi August 14, 2024 08:11
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit a4aed0a into vuejs:master Sep 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum depth of template block
3 participants