-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix siblings and interleaving issues reported in #2342 #2348
Fix siblings and interleaving issues reported in #2342 #2348
Conversation
Hi @FloEdelmann, thank you for reporting #2342, I have hopefully addressed those here, please let me know if I missed something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not yet looked into your implementation, but I noticed one wrong test case.
@felipemelendez Are you still interested in fixing this? |
Yes! Sorry for the delay, I had a family emergency at the start of the year, so I've been distracted to say the least; I'll get back on this soon! |
No worries, there's more important stuff in life than coding 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
This PR addresses the bugs reported in #2342
And added tests