-
-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1819: Enforce order between script and script setup #1825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR!
I wrote comments. I also want @FloEdelmann 's opinion on the option format.
I also think that existing options should continue to work, i.e. I really like the CSS selector format suggestion by @ota-meshi. It's really clear and concise, and allows configuring e.g. The object format is too noisy for me. |
@FloEdelmann Thank you for your opinion.
I agree with you 👍 @doug-wade Can you change this PR so that user can specify a CSS selector as an option? If it's difficult to parse the CSS selector, could you add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for implementing the feedback!
@ota-meshi can you have another look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for changing this PR.
I will follow up about postcss-selector-parser
later, so I commented on other things.
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
Co-authored-by: Yosuke Ota <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
Fixes #1819 . Adds a new tag type to the component-tags-order, script/setup.