Add multi-word-component-names rule
#1661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
csordasmarton
commented
Oct 17, 2021
csordasmarton
commented
Contributor
Author
|
Netlify gives me the following error: |
ota-meshi
requested changes
Oct 17, 2021
Member
ota-meshi
left a comment
ota-meshi
left a comment
There was a problem hiding this comment.
Thanks for this PR!!!
I think the implementation of the rule is mostly good. However, I have some change requests.
csordasmarton
force-pushed
the
multi_world_component_names
branch
from
158c459 to
824d35a
Compare
Contributor
Author
|
@ota-meshi Thanks for your comments 😊 I think I have fixed all of your comments. |
ota-meshi
approved these changes
Oct 18, 2021
Member
ota-meshi
left a comment
ota-meshi
left a comment
There was a problem hiding this comment.
LGTM! Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.