-
-
Notifications
You must be signed in to change notification settings - Fork 669
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add prefer-use-template-ref rule (#2554)
Co-authored-by: Flo Edelmann <[email protected]>
- Loading branch information
1 parent
e13089e
commit a5fb774
Showing
5 changed files
with
485 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
--- | ||
pageClass: rule-details | ||
sidebarDepth: 0 | ||
title: vue/prefer-use-template-ref | ||
description: require using `useTemplateRef` instead of `ref` for template refs | ||
--- | ||
|
||
# vue/prefer-use-template-ref | ||
|
||
> require using `useTemplateRef` instead of `ref` for template refs | ||
- :exclamation: <badge text="This rule has not been released yet." vertical="middle" type="error"> _**This rule has not been released yet.**_ </badge> | ||
|
||
## :book: Rule Details | ||
|
||
Vue 3.5 introduced a new way of obtaining template refs via | ||
the [`useTemplateRef()`](https://vuejs.org/guide/essentials/template-refs.html#accessing-the-refs) API. | ||
|
||
This rule enforces using the new `useTemplateRef` function instead of `ref` for template refs. | ||
|
||
<eslint-code-block :rules="{'vue/prefer-use-template-ref': ['error']}"> | ||
|
||
```vue | ||
<template> | ||
<button ref="submitRef">Submit</button> | ||
<button ref="closeRef">Close</button> | ||
</template> | ||
<script setup> | ||
import { ref, useTemplateRef } from 'vue'; | ||
/* ✓ GOOD */ | ||
const submitRef = useTemplateRef('submitRef'); | ||
const submitButton = useTemplateRef('submitRef'); | ||
const closeButton = useTemplateRef('closeRef'); | ||
/* ✗ BAD */ | ||
const closeRef = ref(); | ||
</script> | ||
``` | ||
|
||
</eslint-code-block> | ||
|
||
This rule skips `ref` template function refs as these should be used to allow custom implementation of storing `ref`. If you prefer | ||
`useTemplateRef`, you have to change the value of the template `ref` to a string. | ||
|
||
<eslint-code-block :rules="{'vue/prefer-use-template-ref': ['error']}"> | ||
|
||
```vue | ||
<template> | ||
<button :ref="ref => button = ref">Content</button> | ||
</template> | ||
<script setup> | ||
import { ref } from 'vue'; | ||
/* ✓ GOOD */ | ||
const button = ref(); | ||
</script> | ||
``` | ||
|
||
</eslint-code-block> | ||
|
||
## :wrench: Options | ||
|
||
Nothing. | ||
|
||
## :mag: Implementation | ||
|
||
- [Rule source](https://github.com/vuejs/eslint-plugin-vue/blob/master/lib/rules/prefer-use-template-ref.js) | ||
- [Test source](https://github.com/vuejs/eslint-plugin-vue/blob/master/tests/lib/rules/prefer-use-template-ref.js) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,89 @@ | ||
/** | ||
* @author Thomasan1999 | ||
* See LICENSE file in root directory for full license. | ||
*/ | ||
'use strict' | ||
|
||
const utils = require('../utils') | ||
|
||
/** @param expression {Expression | null} */ | ||
function expressionIsRef(expression) { | ||
// @ts-ignore | ||
return expression?.callee?.name === 'ref' | ||
} | ||
|
||
/** @type {import("eslint").Rule.RuleModule} */ | ||
module.exports = { | ||
meta: { | ||
type: 'suggestion', | ||
docs: { | ||
description: | ||
'require using `useTemplateRef` instead of `ref` for template refs', | ||
categories: undefined, | ||
url: 'https://eslint.vuejs.org/rules/prefer-use-template-ref.html' | ||
}, | ||
schema: [], | ||
messages: { | ||
preferUseTemplateRef: "Replace 'ref' with 'useTemplateRef'." | ||
} | ||
}, | ||
/** @param {RuleContext} context */ | ||
create(context) { | ||
/** @type Set<string> */ | ||
const templateRefs = new Set() | ||
|
||
/** | ||
* @typedef ScriptRef | ||
* @type {{node: Expression, ref: string}} | ||
*/ | ||
|
||
/** | ||
* @type ScriptRef[] */ | ||
const scriptRefs = [] | ||
|
||
return utils.compositingVisitors( | ||
utils.defineTemplateBodyVisitor( | ||
context, | ||
{ | ||
'VAttribute[directive=false]'(node) { | ||
if (node.key.name === 'ref' && node.value?.value) { | ||
templateRefs.add(node.value.value) | ||
} | ||
} | ||
}, | ||
{ | ||
VariableDeclarator(declarator) { | ||
if (!expressionIsRef(declarator.init)) { | ||
return | ||
} | ||
|
||
scriptRefs.push({ | ||
// @ts-ignore | ||
node: declarator.init, | ||
// @ts-ignore | ||
ref: declarator.id.name | ||
}) | ||
} | ||
} | ||
), | ||
{ | ||
'Program:exit'() { | ||
for (const templateRef of templateRefs) { | ||
const scriptRef = scriptRefs.find( | ||
(scriptRef) => scriptRef.ref === templateRef | ||
) | ||
|
||
if (!scriptRef) { | ||
continue | ||
} | ||
|
||
context.report({ | ||
node: scriptRef.node, | ||
messageId: 'preferUseTemplateRef' | ||
}) | ||
} | ||
} | ||
} | ||
) | ||
} | ||
} |
Oops, something went wrong.