chore: use trailing commas & verify in CI (#161)

.eslintrc.cjs

@@ -6,12 +6,12 @@ module.exports = defineConfig({
 	extends: [
 		'eslint:recommended',
 		'plugin:n/recommended',
-		'plugin:@typescript-eslint/recommended'
+		'plugin:@typescript-eslint/recommended',
 	],
 	parser: '@typescript-eslint/parser',
 	parserOptions: {
 		sourceType: 'module',
-		ecmaVersion: 2021
+		ecmaVersion: 2021,
 	},
 	rules: {
 		eqeqeq: ['warn', 'always', { null: 'never' }],
@@ -22,11 +22,11 @@ module.exports = defineConfig({
 		'prefer-const': [
 			'warn',
 			{
-				destructuring: 'all'
-			}
+				destructuring: 'all',
+			},
 		],
 		'n/no-missing-import': 'off', // doesn't like ts imports
 		'n/no-process-exit': 'off',
-		'@typescript-eslint/no-explicit-any': 'off' // we use any in some places
-	}
+		'@typescript-eslint/no-explicit-any': 'off', // we use any in some places
+	},
 })

.github/renovate.json5

@@ -8,8 +8,8 @@
 	"packageRules": [
 		{
 			"depTypeList": ["peerDependencies"],
-			"enabled": false
-		}
+			"enabled": false,
+		},
 	],
-	"ignoreDeps": []
+	"ignoreDeps": [],
 }

.github/workflows/ci.yml

@@ -25,6 +25,8 @@ jobs:
           cache-dependency-path: "**/pnpm-lock.yaml"
       - name: install
         run: pnpm install --frozen-lockfile --prefer-offline
+      - name: format
+        run: pnpm format
       - name: lint
         run: pnpm run lint
       - name: audit

.prettierrc.json

@@ -4,7 +4,7 @@
 	"tabWidth": 2,
 	"singleQuote": true,
 	"printWidth": 80,
-	"trailingComma": "none",
+	"trailingComma": "all",
 	"overrides": [
 		{
 			"files": ["*.json5"],

builds/vite-plugin-react.ts

@@ -5,10 +5,10 @@ export async function build(options: RunOptions) {
 	return runInRepo({
 		...options,
 		repo: 'vitejs/vite-plugin-react',
-		build: 'build'
+		build: 'build',
 	})
 }
 
 export const packages = {
-	'@vitejs/plugin-react':'packages/plugin-react'
+	'@vitejs/plugin-react': 'packages/plugin-react',
 }

builds/vite-plugin-svelte.ts

@@ -7,12 +7,12 @@ export async function build(options: RunOptions) {
 		repo: 'sveltejs/vite-plugin-svelte',
 		branch: options.viteMajor === 4 ? 'vite-4' : 'main',
 		overrides: {
-			svelte: 'latest'
+			svelte: 'latest',
 		},
-		build: 'build'
+		build: 'build',
 	})
 }
 
 export const packages = {
-	'@sveltejs/vite-plugin-svelte':'packages/vite-plugin-svelte',
+	'@sveltejs/vite-plugin-svelte': 'packages/vite-plugin-svelte',
 }

builds/vite-plugin-vue.ts

@@ -1,4 +1,4 @@
-import { runInRepo} from '../utils'
+import { runInRepo } from '../utils'
 import { RunOptions } from '../types'
 
 export async function build(options: RunOptions) {
@@ -10,6 +10,6 @@ export async function build(options: RunOptions) {
 }
 
 export const packages = {
-	'@vitejs/plugin-vue':'packages/plugin-vue',
-	'@vitejs/plugin-vue-jsx':'packages/plugin-vue-jsx'
+	'@vitejs/plugin-vue': 'packages/plugin-vue',
+	'@vitejs/plugin-vue-jsx': 'packages/plugin-vue-jsx',
 }

discord-webhook.ts

@@ -16,16 +16,16 @@ type Env = {
 const statusConfig = {
 	success: {
 		color: parseInt('57ab5a', 16),
-		emoji: ':white_check_mark:'
+		emoji: ':white_check_mark:',
 	},
 	failure: {
 		color: parseInt('e5534b', 16),
-		emoji: ':x:'
+		emoji: ':x:',
 	},
 	cancelled: {
 		color: parseInt('768390', 16),
-		emoji: ':stop_button:'
-	}
+		emoji: ':stop_button:',
+	},
 }
 
 async function run() {
@@ -34,7 +34,7 @@ async function run() {
 	}
 	if (!process.env.DISCORD_WEBHOOK_URL) {
 		console.warn(
-			"Skipped beacuse process.env.DISCORD_WEBHOOK_URL was empty or didn't exist"
+			"Skipped beacuse process.env.DISCORD_WEBHOOK_URL was empty or didn't exist",
 		)
 		return
 	}
@@ -64,17 +64,17 @@ async function run() {
 			{
 				title: `${statusConfig[env.STATUS].emoji}  ${env.SUITE}`,
 				description: await createDescription(env.SUITE, targetText),
-				color: statusConfig[env.STATUS].color
-			}
-		]
+				color: statusConfig[env.STATUS].color,
+			},
+		],
 	}
 
 	const res = await fetch(env.DISCORD_WEBHOOK_URL, {
 		method: 'POST',
 		headers: {
-			'Content-Type': 'application/json'
+			'Content-Type': 'application/json',
 		},
-		body: JSON.stringify(webhookContent)
+		body: JSON.stringify(webhookContent),
 	})
 	if (res.ok) {
 		console.log('Sent Webhook')
@@ -85,7 +85,7 @@ async function run() {
 
 function assertEnv<T>(
 	name: string,
-	value: T
+	value: T,
 ): asserts value is Exclude<T, undefined> {
 	if (!value) {
 		throw new Error(`process.env.${name} is empty or does not exist.`)
@@ -101,7 +101,7 @@ async function createRunUrl(suite: string) {
 
 	// when matrix
 	const jobM = result.jobs.find(
-		(job) => job.name === `${process.env.GITHUB_JOB} (${suite})`
+		(job) => job.name === `${process.env.GITHUB_JOB} (${suite})`,
 	)
 	return jobM?.html_url
 }
@@ -115,8 +115,8 @@ async function fetchJobs() {
 	const url = `${process.env.GITHUB_API_URL}/repos/${process.env.GITHUB_REPOSITORY}/actions/runs/${process.env.GITHUB_RUN_ID}/jobs`
 	const res = await fetch(url, {
 		headers: {
-			Accept: 'application/vnd.github.v3+json'
-		}
+			Accept: 'application/vnd.github.v3+json',
+		},
 	})
 	const result = await res.json()
 	return result as { jobs: GitHubActionsJob[] }
@@ -134,7 +134,7 @@ function createTargetText(
 	refType: RefType,
 	ref: string,
 	permRef: string | undefined,
-	repo: string
+	repo: string,
 ) {
 	const repoText = repo !== 'vitejs/vite' ? `${repo}:` : ''
 	if (refType === 'branch') {

ecosystem-ci.ts

@@ -3,7 +3,14 @@ import path from 'path'
 import process from 'process'
 import { cac } from 'cac'
 
-import {setupEnvironment, setupViteRepo, buildVite, bisectVite, parseViteMajor, parseMajorVersion} from './utils'
+import {
+	setupEnvironment,
+	setupViteRepo,
+	buildVite,
+	bisectVite,
+	parseViteMajor,
+	parseMajorVersion,
+} from './utils'
 import { CommandOptions, RunOptions } from './types'
 
 const cli = cac()
@@ -18,11 +25,11 @@ cli
 	.action(async (suites, options: CommandOptions) => {
 		const { root, vitePath, workspace } = await setupEnvironment()
 		const suitesToRun = getSuitesToRun(suites, root)
-		let viteMajor;
+		let viteMajor
 		if (!options.release) {
 			await setupViteRepo(options)
 			await buildVite({ verify: options.verify })
-			viteMajor = parseViteMajor(vitePath);
+			viteMajor = parseViteMajor(vitePath)
 		} else {
 			viteMajor = parseMajorVersion(options.release)
 		}
@@ -33,7 +40,7 @@ cli
 			workspace,
 			release: options.release,
 			verify: options.verify,
-			skipGit: false
+			skipGit: false,
 		}
 		for (const suite of suitesToRun) {
 			await run(suite, runOptions)
@@ -43,7 +50,7 @@ cli
 cli
 	.command('build-vite', 'build vite only')
 	.option('--verify', 'verify vite checkout by running tests', {
-		default: false
+		default: false,
 	})
 	.option('--repo <repo>', 'vite repository to use', { default: 'vitejs/vite' })
 	.option('--branch <branch>', 'vite branch to use', { default: 'main' })
@@ -60,7 +67,7 @@ cli
 	.option(
 		'--verify',
 		'verify checkout by running tests before using local vite',
-		{ default: false }
+		{ default: false },
 	)
 	.option('--repo <repo>', 'vite repository to use', { default: 'vitejs/vite' })
 	.option('--release <version>', 'vite release to use from npm registry')
@@ -72,7 +79,7 @@ cli
 			root,
 			vitePath,
 			viteMajor: parseViteMajor(vitePath),
-			workspace
+			workspace,
 		}
 		for (const suite of suitesToRun) {
 			await run(suite, runOptions)
@@ -82,7 +89,7 @@ cli
 cli
 	.command(
 		'bisect [...suites]',
-		'use git bisect to find a commit in vite that broke suites'
+		'use git bisect to find a commit in vite that broke suites',
 	)
 	.option('--good <ref>', 'last known good ref, e.g. a previous tag. REQUIRED!')
 	.option('--verify', 'verify checkouts by running tests', { default: false })
@@ -93,7 +100,7 @@ cli
 	.action(async (suites, options: CommandOptions & { good: string }) => {
 		if (!options.good) {
 			console.log(
-				'you have to specify a known good version with `--good <commit|tag>`'
+				'you have to specify a known good version with `--good <commit|tag>`',
 			)
 			process.exit(1)
 		}
@@ -111,7 +118,7 @@ cli
 						root,
 						vitePath,
 						viteMajor: parseViteMajor(vitePath),
-						workspace
+						workspace,
 					})
 				}
 				isFirstRun = false
@@ -135,7 +142,7 @@ async function run(suite: string, options: RunOptions) {
 	const { test } = await import(`./tests/${suite}.ts`)
 	await test({
 		...options,
-		workspace: path.resolve(options.workspace, suite)
+		workspace: path.resolve(options.workspace, suite),
 	})
 }
 
@@ -150,7 +157,7 @@ function getSuitesToRun(suites: string[], root: string) {
 		suitesToRun = availableSuites
 	} else {
 		const invalidSuites = suitesToRun.filter(
-			(x) => !x.startsWith('_') && !availableSuites.includes(x)
+			(x) => !x.startsWith('_') && !availableSuites.includes(x),
 		)
 		if (invalidSuites.length) {
 			console.log(`invalid suite(s): ${invalidSuites.join(', ')}`)

tests/_hydrogen.ts

@@ -6,6 +6,6 @@ export async function test(options: RunOptions) {
 		...options,
 		repo: 'Shopify/hydrogen',
 		build: 'build',
-		test: 'test:vite-ci'
+		test: 'test:vite-ci',
 	})
 }

tests/_selftest.ts

@@ -13,18 +13,18 @@ export async function test(options: RunOptions) {
 			const pkg = JSON.parse(await fs.promises.readFile(pkgFile, 'utf-8'))
 			if (pkg.name !== 'vite-ecosystem-ci') {
 				throw new Error(
-					`invalid checkout, expected package.json with "name":"vite-ecosystem-ci" in ${dir}`
+					`invalid checkout, expected package.json with "name":"vite-ecosystem-ci" in ${dir}`,
 				)
 			}
 			pkg.scripts.selftestscript =
 				"[ -d ../../vite/packages/vite/dist ] || (echo 'vite build failed' && exit 1)"
 			await fs.promises.writeFile(
 				pkgFile,
 				JSON.stringify(pkg, null, 2),
-				'utf-8'
+				'utf-8',
 			)
 		},
 		test: 'pnpm run selftestscript',
-		verify: false
+		verify: false,
 	})
 }

tests/astro.ts

@@ -7,6 +7,6 @@ export async function test(options: RunOptions) {
 		repo: 'withastro/astro',
 		branch: 'main',
 		build: 'build:ci',
-		test: 'test:vite-ci'
+		test: 'test:vite-ci',
 	})
 }

tests/histoire.ts

@@ -6,6 +6,6 @@ export async function test(options: RunOptions) {
 		...options,
 		repo: 'histoire-dev/histoire',
 		build: 'build',
-		test: ['test', 'test:examples']
+		test: ['test', 'test:examples'],
 	})
 }

tests/iles.ts

@@ -5,11 +5,11 @@ export async function test(options: RunOptions) {
 	await runInRepo({
 		...options,
 		repo: 'ElMassimo/iles',
-		overrides:{
-			"@vitejs/plugin-vue": true
+		overrides: {
+			'@vitejs/plugin-vue': true,
 		},
 		beforeInstall: async () => $`git lfs install && git lfs pull`,
 		build: 'build:all',
-		test: 'test'
+		test: 'test',
 	})
 }

tests/ladle.ts

@@ -8,6 +8,6 @@ export async function test(options: RunOptions) {
 		branch: options.viteMajor === 4 ? 'vite-4' : 'main',
 		build: 'build',
 		beforeTest: 'pnpm playwright install chromium',
-		test: 'test'
+		test: 'test',
 	})
 }

tests/laravel.ts

@@ -3,11 +3,11 @@ import { RunOptions } from '../types'
 
 export async function test(options: RunOptions) {
 	//see https://github.com/laravel/vite-plugin/blob/73466441b0c9eb0c1a5ce0a0e937bd83eaef4b70/.github/workflows/tests.yml#L10
-	process.env.LARAVEL_BYPASS_ENV_CHECK="1";
+	process.env.LARAVEL_BYPASS_ENV_CHECK = '1'
 	await runInRepo({
 		...options,
 		repo: 'laravel/vite-plugin',
 		build: 'build',
-		test: 'test'
+		test: 'test',
 	})
 }

tests/marko.ts

@@ -9,7 +9,7 @@ export async function test(options: RunOptions) {
 		build: 'build',
 		test: 'test',
 		overrides: {
-			esbuild: `${options.vitePath}/packages/vite/node_modules/esbuild`
-		}
+			esbuild: `${options.vitePath}/packages/vite/node_modules/esbuild`,
+		},
 	})
 }