Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: og preview #2633

Merged
merged 5 commits into from
Dec 28, 2023
Merged

fix: og preview #2633

merged 5 commits into from
Dec 28, 2023

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Dec 28, 2023

Copy link

netlify bot commented Dec 28, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit b4fb291
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/658dcdc01f6e0e0008d81182
😎 Deploy Preview https://deploy-preview-2633--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brc-dd
Copy link
Member

brc-dd commented Dec 28, 2023

Logo as an og:image is not a good idea. It will be stretched/cropped most likely while sharing. 1200 x 630 px image is usually recommended.

@himself65
Copy link
Contributor Author

himself65 commented Dec 28, 2023

Logo as an og:image is not a good idea. It will be stretched/cropped most likely while sharing. 1200 x 630 px image is usually recommended.

I just found that vue2 is using the same image. Is there any better image to use?

https://www.opengraph.xyz/url/https%3A%2F%2Fv2.vuejs.org%2F

@brc-dd
Copy link
Member

brc-dd commented Dec 28, 2023

Yeah but in the previews you see how that thing is looking weird.

@brc-dd
Copy link
Member

brc-dd commented Dec 28, 2023

Facebook:

image

LinkedIn:

image

Twitter:

image

Discord:

image

WhatsApp:

image

Copy link
Member

@brc-dd brc-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted things a bit. This looks fine for most of the stuff except LinkedIn (and certain padding issues if one looks closely). I'll ask Kia to design some cool image for this and we can replace that later.

@brc-dd brc-dd merged commit 658ed80 into vuejs:main Dec 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no og preview
2 participants