Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to V2 migration docs about change in transition class names #359

Closed
BenRutlandWeb opened this issue Jul 30, 2020 · 5 comments
Closed
Assignees

Comments

@BenRutlandWeb
Copy link

What problem does this feature solve?

I spent hours trying to debug transitions not working. The reason being .v-enter/.v-leave has changed to .v-enter-from/.v-leave-from.

I'm aware that the docs are a work in progress but I'd hate for early adopters to waste as much time as I just did!

This is possible not the correct place for this comment but I don't know where else it should go.

Great work on the new version BTW!

What does the proposed API look like?

A paragraph on the v3 docs site, in the migration from v2 section, detailing the change in class names.

@yyx990803 yyx990803 transferred this issue from vuejs/core Jul 30, 2020
@bencodezen bencodezen assigned bencodezen and sdras and unassigned bencodezen Jul 31, 2020
@bencodezen
Copy link
Member

Related to #138

@NataliaTepluhina
Copy link
Member

@BenRutlandWeb @bencodezen we actually have this paragraph on migration guide:

Screenshot 2020-08-02 at 13 00 25

(also, API docs were already updated with correct class names).

I agree we'd need to have a dedicated section on this though 😅

@BenRutlandWeb
Copy link
Author

🤦 That's easy to miss!

@bencodezen
Copy link
Member

@BenRutlandWeb Totally understandable. We hope to have an official section in the Migration Guide on transitions soon!

@bencodezen
Copy link
Member

We now have a guide thanks to @sdras!

https://v3.vuejs.org/guide/migration/transition.html#overview

alexeyvokin pushed a commit to alexeyvokin/docs-ru_old that referenced this issue Apr 1, 2024
* feat: translation for rules recommended C

* fix: title recommendation

* Update rules-recommended.md

---------

Co-authored-by: Bochkarev Ivan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants