Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reactivity): clean effect code #9680

Closed
wants to merge 2 commits into from

Conversation

Doctor-wu
Copy link
Member

No description provided.

@skirtles-code
Copy link
Contributor

I believe this code has already been removed on the minor branch for 3.4, due to other changes.

I think the original code was written that way to try to improve minification. My understanding is that some minifiers can detect the unnecessary parameter and remove it, but others can't. I haven't checked this recently, so I'm not sure whether this is still the case. This PR currently doesn't have a description, so it's unclear to me whether this has been taken into account.

@Doctor-wu
Copy link
Member Author

Sry for the empty description, this PR considered the trigger code style (caz track function is written in this style), and I think that part is unnecessary, so I changed the code to align this

trackEffects(dep, eventInfo)

@pikax
Copy link
Member

pikax commented Nov 30, 2023

@Doctor-wu thank you for the PR, as Skirtles said, in the minor that lines no longer exists.

There was a big refactoring on the reactivity #5912

@pikax pikax closed this Nov 30, 2023
@Doctor-wu
Copy link
Member Author

@pikax That's also great news, thx for your reply~

@Doctor-wu Doctor-wu deleted the chore/clean-effect-code branch November 30, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants