Skip to content

fix(renderer): fix patch error in unstable slot #9202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
linghaoSu wants to merge 2 commits into from
Closed

fix(renderer): fix patch error in unstable slot #9202

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f45875
fix(renderer): fix patch error in unstable slot
linghaoSu Sep 13, 2023
3ec274b
test(render): add unit test for rendererFragment
linghaoSu Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/runtime-core/src/renderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,7 +1098,9 @@ function baseCreateRenderer(
dynamicChildren &&
// #2715 the previous fragment could've been a BAILed one as a result
// of renderSlot() with no valid children
n1.dynamicChildren
n1.dynamicChildren &&
// #9200 in some case stable fragment in deep unstable slot
n1?.children?.length === n2?.children?.length

@Alfred-Skyblue Alfred-Skyblue Sep 13, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid using optional chaining #4882 (comment)

@linghaoSu linghaoSu Sep 13, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed optional chaining

@edison1105 edison1105 Sep 13, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
n1?.children?.length === n2?.children?.length
dynamicChildren.length === n1.dynamicChildren.length

@linghaoSu linghaoSu Sep 13, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

) {
// a stable fragment (template root or <template v-for>) doesn't need to
// patch children order, but it may contain dynamicChildren.
Expand Down