Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: return early when children == null #9041

Closed
wants to merge 1 commit into from

Conversation

chenfan0
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Aug 25, 2023

@chenfan0 is attempting to deploy a commit to the vuejs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB (+17 B) 32.6 kB (+4 B) 29.5 kB (+19 B)
vue.global.prod.js 132 kB (+17 B) 49.3 kB (+5 B) 44.3 kB (-1 B)

Usages

Name Size Gzip Brotli
createApp 47.9 kB (+17 B) 18.8 kB (+2 B) 17.2 kB (+5 B)
createSSRApp 50.7 kB (+17 B) 19.9 kB (+1 B) 18.2 kB (+7 B)
defineCustomElement 50.3 kB (+17 B) 19.6 kB (+2 B) 18 kB (+65 B)
overall 61.3 kB (+17 B) 23.7 kB (+5 B) 21.6 kB (+16 B)

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! We presently do not entertain stylistic refinements, unless they demonstrably contribute significantly to performance or bundle size reduction. Could you provide evidence to substantiate this?

@sxzz sxzz added need more info Further information is requested wait changes labels Aug 31, 2023
@yyx990803
Copy link
Member

children being nullish is a relatively rare codepath so I don't think this will result in meaningful performance difference. The original code compresses better.

@yyx990803 yyx990803 closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need more info Further information is requested wait changes
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

3 participants