Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-element): correctly handle number type props in prod #8989

Merged
merged 23 commits into from
Dec 6, 2023

Conversation

baiwusanyu-c
Copy link
Member

@baiwusanyu-c baiwusanyu-c commented Aug 16, 2023

close: #8987

@baiwusanyu-c baiwusanyu-c marked this pull request as ready for review August 16, 2023 16:07
@sxzz sxzz changed the title fix(custom-element): Correctly handle number type props in prod fix(custom-element): correctly handle number type props in prod Aug 18, 2023
packages/compiler-sfc/src/script/defineProps.ts Outdated Show resolved Hide resolved
packages/compiler-sfc/src/script/defineProps.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 21, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.7 kB 33 kB 29.8 kB
vue.global.prod.js 133 kB 49.8 kB 44.7 kB

Usages

Name Size Gzip Brotli
createApp 48.2 kB 19 kB 17.3 kB
createSSRApp 51.5 kB 20.3 kB 18.5 kB
defineCustomElement 50.6 kB 19.7 kB 18 kB
overall 61.6 kB 23.8 kB 21.7 kB

@baiwusanyu-c baiwusanyu-c requested a review from sxzz August 22, 2023 02:18
@sxzz sxzz added the ready to merge The PR is ready to be merged. label Aug 22, 2023
@SavkaTaras
Copy link

Hello @baiwusanyu-c , could you please merge this PR, once all approved? Thank you so much!

@sxzz
Copy link
Member

sxzz commented Aug 24, 2023

@SavkaTaras Hi, we Vue team has a specific cycle to merge PRs and release, please be patient ❤️

@SavkaTaras
Copy link

@SavkaTaras Hi, we Vue team has a specific cycle to merge PRs and release, please be patient ❤️

@sxzz thank you so much! I appreciate it.

@SavkaTaras
Copy link

Hello @edison1105 , could you please review this at your convenience?
We are kindly waiting on this to be released...

Thank you.

@LinusBorg
Copy link
Member

@edison1105 This is technically pending your review. Can you have a look or cancel your review? I think this is good to go.

@edison1105
Copy link
Member

@LinusBorg approved

@SavkaTaras
Copy link

Hello @baiwusanyu-c @sxzz @LinusBorg @edison1105 ,

Can you please merge this and release when possible?

Thank you

@LinusBorg LinusBorg merged commit d74d364 into vuejs:main Dec 6, 2023
11 checks passed
@baiwusanyu-c baiwusanyu-c deleted the bwsy/fix/CENumProps branch December 6, 2023 07:18
@yyx990803
Copy link
Member

@sxzz looks like this will need to merge and publish the corresponding changes in the Vite plugin, I'll leave that to you

@sxzz
Copy link
Member

sxzz commented Dec 7, 2023

Released as [email protected]

@SavkaTaras
Copy link

Released as [email protected]

Hello, is it possible to release 4.5.2? Thank you

@sxzz
Copy link
Member

sxzz commented Dec 7, 2023

Released as [email protected] too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: custom elements
Projects
Development

Successfully merging this pull request may close these issues.

Vue3 custom element prop type number is a string in production.
6 participants