Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test case on $el #7922

Merged
merged 2 commits into from
Mar 25, 2023
Merged

test: improve test case on $el #7922

merged 2 commits into from
Mar 25, 2023

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Mar 21, 2023 •
edited
Loading

No description provided.

@sxzz
Copy link
Member

sxzz commented Mar 21, 2023

/ecosystem-ci run

@vue-bot

This comment was marked as outdated.

Sign in to view
@himself65
Copy link
Contributor Author

I read the code here. I think this should be unknown actually. but since it already any, it would be a breaking change

@himself65 himself65 changed the title fix: $el type test: improve test case on $el Mar 21, 2023
@himself65
Copy link
Contributor Author

/cc @sxzz I've updated the PR content because I think to remove any is unreachable for now

@yyx990803 yyx990803 merged commit cbc2733 into vuejs:main Mar 25, 2023
IAmSSH pushed a commit to IAmSSH/core that referenced this pull request May 14, 2023
@himself65 @IAmSSH
test: improve test case on $el (vuejs#7922)
2de187c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@himself65 @sxzz @vue-bot @yyx990803